Update checkstyle to 13.9.0.

.github/workflows/checkstyle.yml

@@ -13,6 +13,9 @@ on:
   pull_request:
     branches: [ main ]
 
+env:
+  JDK_VERSION: 21
+  JDK_DISTRO: 'temurin'
 jobs:
   analyze_sources:
     name: "Is there any Java source code to lint?"
@@ -68,11 +71,18 @@ jobs:
     - name: "Checkout sources"
       uses: actions/checkout@v7
 
+    - name: Set up JDK ${{ env.JDK_VERSION }} ${{ env.JDK_DISTRO }}
+      uses: actions/setup-java@v6
+      with:
+        java-version: ${{ env.JDK_VERSION }}
+        distribution: ${{ env.JDK_DISTRO }}
+
     - name: "Lint changed files"
       run: |
         # Run CheckStyle
         # https://github.com/checkstyle/checkstyle/releases/
-        CHECKSTYLE_VERSION="10.3.4"
+        # Version should match the version in build.gradle.kts.
+        CHECKSTYLE_VERSION="13.9.0"
         JAR="checkstyle-${CHECKSTYLE_VERSION}-all.jar"
         URL="https://github.com/checkstyle/checkstyle/releases/download/checkstyle-${CHECKSTYLE_VERSION}/${JAR}"
 

build.gradle.kts

@@ -1052,8 +1052,8 @@ tasks {
 
   // Checkstyles related tasks: "checkstylMain" and "checkstyleTest"
   checkstyle {
-    // Checkstyle version to use
-    toolVersion = "10.3.4"
+    // Checkstyle version to use. Should match version in checkstyle workflow.
+    toolVersion = "13.9.0"
 
     // let's use google_checks.xml config provided with Checkstyle.
     // https://stackoverflow.com/a/67513272/1235698

checkstyle-suppressions.xml

@@ -7,12 +7,15 @@
     <suppress checks="MissingJavadocMethod"/>
     <suppress checks="MissingJavadocType"/>
     <suppress checks="JavadocParagraph"/>
+    <suppress checks="JavadocContentLocation"/>
     <suppress checks="NeedBraces"/>
     <suppress checks="LineLength"/>
 
     <suppress checks="LocalVariableName"/>
+    <suppress checks="LocalFinalVariableName"/>
     <suppress checks="ParameterName"/>
     <suppress checks="MemberName"/>
+    <suppress checks="GoogleNonConstantFieldName"/>
     <suppress checks="TypeName"/>
     <suppress checks="VariableDeclarationUsageDistance"/>
     <suppress checks="AbbreviationAsWordInName"/>
@@ -21,6 +24,8 @@
     <suppress checks="MissingSwitchDefault"/>
     <suppress checks="MultipleVariableDeclarations"/>
     <suppress checks="EmptyBlock"/>
+    <suppress checks="TextBlockGoogleStyleFormatting"/>
+    <suppress checks="SingleSpaceSeparator"/>
     <suppress checks="EmptyLineSeparator"/>
     <suppress checks="NonEmptyAtclauseDescription"/>
     <suppress checks="SummaryJavadoc"/>
@@ -28,7 +33,4 @@
     <suppress checks="CustomImportOrder"/>
     <suppress checks="SingleLineJavadoc"/>
     <suppress checks="FallThrough"/>
-
-    <!-- Auto-generated file. https://github.com/logisim-evolution/logisim-evolution/issues/563-->
-    <suppress id="VhdlSyntax" files="src/main/java/com/cburch/logisim/vhdl/syntax/VhdlSyntax.java"/>
 </suppressions>